[Benchmark] finished rust bench_lat with latest latency of 2.5us in average

SHiftLin commented 2 years ago

Why are these changes needed?

Related issue number

Checks

[ ] I've run scripts/format.sh to lint the changes in this PR.
[ ] I've run scripts/clippy.sh to lint the changes in this PR.
[ ] I've included any doc changes.
[ ] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [ ] Release tests
- [ ] This PR is not tested :(

crazyboycjr commented 2 years ago

Looks great to me! Except one thing is that I would use more descriptive and specific names for types and variables. I would change Verb to Op/Operation, Test to TestType/BenchType, and num to some other concrete name ('num' is too general).

Another thing is that I would let the structopt decide the option name, so instead of writing #[structopt(short = "w", long = "warmup", default_value = "100")] I would rather use #[structopt(short, long, default_value = "100")].

We can change these later. Great work!

crazyboycjr commented 2 years ago

Closes #47

phoenix-dataplane / phoenix