hostutils/phoenixd: break from loop after connection lost on port

niewim19 commented 3 years ago

JIRA: PD-29

phoenixd closes itself after connection lost

Description

break from loop in message dispatch in phoenixd

Motivation and Context

This change allows for further automation of development process. User may create a bash script that rapidly runs the phoenixd, thus user does not have to "aim" with phoenixd when plo starts.

Change allows easy "run in background" for phoenixd

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

[ ] Already covered by automatic testing.
[ ] New test added: (add PR link here).
[x] Tested by hand on: imxrt1064.

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing linter checks and tests passed.
[x] My changes generate no new compilation warnings for any of the targets.

Special treatment

[ ] This PR needs additional PRs to work (list the PRs, preferably in merge-order).
[ ] I will merge this PR by myself when appropriate.

niewim19 commented 3 years ago

Thanks, my mistake with imxrt1066. Changed also the commit message

nalajcie commented 3 years ago

@jsarzy - please verify if it won't break testing using test runner

@niewim19: not sure if hostutils prefix in commit message is needed - You're committing to phoenix-rtos-hostutils repo, so that's pretty self-descriptive :)

jsarzy commented 3 years ago

@nalajcie - it breaks the imxrt106x part. As the imxrt106x runner is not launched yet it's not a problem. I'm going to prepare a fix today.

niewim19 commented 3 years ago

@nalajcie Yes, you are right. hostutils was removed from commit message. @jsarzy If the fix is ready please approve PR. This change, aside from future phoenixd refactor really speeds up development @Maxez Please check if this change is not crucial for ia32 on qemu, because (as we spoke) phoenixd is in some cases used on ia32 and there are even comments about it in the code.

jsarzy commented 3 years ago

I didn't have time to prepare a fix, but is not problem right now, so for me it can be merged.

phoenix-rtos / phoenix-rtos-hostutils