plo: new error after last changes: `Can't open file on usb0`

[damianloew]

• after the following changes in plo can't open error may occur in ~1/8 test runner campaigns. Even if it was not seen before, there could be an another reason.

  • 152a cmd: apply changes in interrupts API
  • bdc9 devices: apply changes in interrupts API
  • f6a0 hal/armv7m: allow to disable specific interrupt in NVIC
  • 7718 hal/ia32: apply changes in interrupts hal API
  • 0958 hal/armv7a: allow to disable specific interrupt in GIC

• below is a test runner fail with output from phoenixd:

• after error plo seems to work properly (i. e. sending next commands)

• caught when testing https://github.com/phoenix-rtos/phoenix-rtos-project/commit/1d61317bd06779bc2bcfb08f328f99f276842d76 phoenix-rtos-project with only plo changes (not caught when testing with commits to a6df zynq7000-flash: add erase handler implementation)

• reproduced in 14th test runner campaign, when using the current phoenix-rtos-project revision: https://github.com/phoenix-rtos/phoenix-rtos-project/commit/dc5d14c4f82c7b766546967c4603385f6886f06f

[agkaminski]

I don't really see anything dangerous in these commits, maybe it somehow made some other problem more apparent?

[damianloew]

I think so, please let me know whether I should check something in detail. Maybe it's related to https://github.com/phoenix-rtos/phoenix-rtos-project/issues/489

It seems that new usb driver in plo is needed to solve this problem, like in https://github.com/phoenix-rtos/phoenix-rtos-project/issues/489

[agkaminski]

My thought for future debugging - it might be worth checking if hal_interruptsDisable really do disable interrupt

[damianloew]

It seemed to occur only on damaged imxrt117x-unit, so I think it's probably not a problem with system.

[damianloew]

As it was discovered during nightly run (https://github.com/phoenix-rtos/phoenix-rtos-project/actions/runs/5285224467/jobs/9563608911) this issue may still happen, even on a proper board. This happen for the following phrtos-project revision: https://github.com/phoenix-rtos/phoenix-rtos-project/commit/ab93a3aeac748f002075fb997f1290f87b6bd19e

[damianloew]

Update: very similar issue is still being encountered, both on imxrt106x and imxrt117x. There are usually 2 following error messages:

There is nothing suspicious in dmesg output during those fails. It seems that phoenixd is launched too early and 0.5s sleep after finding an ACM device in test runner solves the problem.

On the second screen the error is caused by failed open() which sets ENOENT errno: https://github.com/phoenix-rtos/phoenix-rtos-hostutils/blob/58629f306cc09e2b01ddcaeb0dbd883d778e7bdb/common/serial.c#L32

The host, where the issue has been reproduced was Raspberry Pi 4B with Raspberry Pi OS Lite 64bit (Debian GNU/Linux 11) without modemManager installed and mtp-probe removed.