phoenix-rtos / phoenix-rtos-project

Sample project using Phoenix-RTOS
https://phoenix-rtos.com
BSD 3-Clause "New" or "Revised" License
43 stars 32 forks source link

sensorhub: possible off-by-one on nul-terminating messages in `pa6h` driver #612

Closed niewim19 closed 1 year ago

niewim19 commented 1 year ago

In pa6h sensorhub driver it is possible that nul-terminating messages at the end of pa6h_receiver():

https://github.com/phoenix-rtos/phoenix-rtos-devices/blob/acb0abfed72acc2611e6a69a41efb20a5fdac34e/sensors/gps/pa6h.c#L186-L188

I am self assigning this issue to not lose it.

niewim19 commented 1 year ago

@kemonats Is this the outside of buffer write issue you have mentioned in one of closed PR-s?

kemonats commented 1 year ago

Yes.

niewim19 commented 1 year ago

Solved via: https://github.com/phoenix-rtos/phoenix-rtos-devices/pull/343