trunner: prevent the screen from clear by escape code in output from fail

mateusz-bloch commented 5 months ago

JIRA: CI-460

Description

Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

[x] Already covered by automatic testing.
[ ] New test added: (add PR link here).
[ ] Tested by hand on: (list targets here).

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing linter checks and tests passed.
[x] My changes generate no new compilation warnings for any of the targets.

Special treatment

[ ] This PR needs additional PRs to work (list the PRs, preferably in merge-order).
[ ] I will merge this PR by myself when appropriate.

github-actions[bot] commented 5 months ago

Unit Test Results

7 484 tests - 241 6 769 :white_check_mark: - 241 38m 21s :stopwatch: + 1m 17s 420 suites - 25 715 :zzz: ± 0 1 files ± 0 0 :x: ± 0

Results for commit 933c44cb. ± Comparison against base commit aba81048.

This pull request removes 241 tests.

``` phoenix-rtos-tests/mem/mmap ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned phoenix-rtos-tests/mem/mmap ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned_file phoenix-rtos-tests/mem/mmap ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/mem/mmap.test_mmap.len__zero phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned_file phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/mem/mmap.test_mmap.len__zero phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned_file phoenix-rtos-tests/mem/mmap ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/mem/mmap.test_mmap.len__zero phoenix-rtos-tests/mem/mmap ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/mem/mmap.test_mmap.len__not_page_aligned … ```

:recycle: This comment has been updated with latest results.

nalajcie commented 5 months ago

Why? IMHO on error we should show data as-is (even garbage) as it might be a part of (or a reason for) an error?

The regex is slightly invalid, also we already have remove_ansi_sequences function available.

damianloew commented 5 months ago

Why? IMHO on error we should show data as-is (even garbage) as it might be a part of (or a reason for) an error?

The regex is slightly invalid, also we already have remove_ansi_sequences function available.

Why? IMHO on error we should show data as-is (even garbage) as it might be a part of (or a reason for) an error?

The regex is slightly invalid, also we already have remove_ansi_sequences function available.

The name of task suggested that we could skip clear screen esc code - I didn't mean to escape all of them. I was considering such solution, because we are running tests using trunner on images that refresh, clear and print the whole output once again and again. Then in case of fail the output is not readable

nalajcie commented 1 month ago

The name of task suggested that we could skip clear screen esc code - I didn't mean to escape all of them. I was considering such solution, because we are running tests using trunner on images that refresh, clear and print the whole output once again and again. Then in case of fail the output is not readable

I still don't get it, the log should be as verbose as it could (if we're removing data from the output we might remove why regex match has failed) . If we're talking about better presentation on screen - it should be done at a different level (just before printing message to screen)?

Also please note that current implementation is slow - using simple replace twice would probably be faster. If we would have multiple things to remove - the least you could do is compile the regex beforehand.

phoenix-rtos / phoenix-rtos-tests