search

phoenix-ru / fervid

All-in-One Vue compiler written in Rust
https://phoenix-ru.github.io/fervid/
Apache License 2.0
371 stars 9 forks source link

fix: clippy errors #4

Closed cijiugechu closed 1 year ago

phoenix-ru commented 1 year ago

I can't accept this PR yet, as I leave (non-clippy) warnings specifically to indicate that there is something missing. For instance, SingleThreadedComments is meant for the /*#__PURE__*/ comment optimization on <script setup> refs (which is an easy optimization not implemented by the js compiler for some reason).

Some other warnings serve the same purpose: to mark something as MVP-critical.

cijiugechu commented 1 year ago

I can't accept this PR yet, as I leave (non-clippy) warnings specifically to indicate that there is something missing. For instance, SingleThreadedComments is meant for the /*#__PURE__*/ comment optimization on <script setup> refs (which is an easy optimization not implemented by the js compiler for some reason).

Some other warnings serve the same purpose: to mark something as MVP-critical.

I see, that's something I hadn't considered; I will be closing this PR, thanks for your reply