search

phoenix-ru / fervid

All-in-One Vue compiler written in Rust
https://phoenix-ru.github.io/fervid/
Apache License 2.0
371 stars 9 forks source link

fix: test error #5

Closed ErKeLost closed 11 months ago

ErKeLost commented 11 months ago
  1. Repair Test error
  2. Maybe we can add ci to make sure every test passes. I can provide pr if you like. And can we add some other ci working like farm ci
phoenix-ru commented 11 months ago

Oh, you're quite right! I usually test with cargo t, and the test you fixed is for the NAPI integration. I only check that NAPI builds and benches.

Yeah, adding the test pipeline would be great. Maybe it can be a phase in the playground workflow? I am not really familiar with GitHub CI and if it's a good idea tbh.

What do you mean by "Farm CI"?

ErKeLost commented 11 months ago

Oh, you're quite right! I usually test with cargo t, and the test you fixed is for the NAPI integration. I only check that NAPI builds and benches.

Yeah, adding the test pipeline would be great. Maybe it can be a phase in the playground workflow? I am not really familiar with GitHub CI and if it's a good idea tbh.

What do you mean by "Farm CI"?

I'm sorry I didn't make it clear. What I meant was that github ci was used to run some necessary tests to prevent unpredictable problems when merging the code. anyway, I think we may access unplugin in the future, so napi should also add js's test guarantee coverage.

Recently, I am also studying the vue compiler, and I would like to study with you if I can.

farm workflows

Farm will be online soon, and 1.0 is looking forward to your plug-in as the official vue plug-in of farm.

phoenix-ru commented 11 months ago

Thanks, I'll take a look at farm's workflows when I have a chance.

I can help you with the Vue compiler internals. Which one are you interested in? :smile:

Regarding Farm plugin, it is tempting indeed, yet I think fervid is not close for its 1.0. Even if the functionality is covering 95% of my usecases, it's only 70% ready for production use.

There are also some DX features planned which the official compiler does not support, but fervid will to make it stand to its "All-in-One" promise. Native integration with Farm is one of such features :wink:

ErKeLost commented 11 months ago

Thank you for your suggestion. I will follow your way to learn the compiler of vue. I am very interested in fervid. I am also looking forward to fervid's dx plan and hope to integrate it into farm as soon as possible. Thank you. I also hope that I can learn something about the compiler and finally, if possible, I can help you to develop together. Thank you very much for your reply

As for the problem that what you said is not applicable to production, I think we can provide a basic plug-in for users to experience in the development environment first, and the production environment can be switched to a part of the existing js plug-in, so that users can use it in advance and find more problems. What do you think?

phoenix-ru commented 11 months ago

Hi @ErKeLost :wave:

How interested are you in contributing to this project? I am a bit wound up with inline mode (this is an optimized mode of compiling SFC when you use <script setup>) and don't have time to implement farms CI atm :( But I checked it, it's pretty smart!

To you and anyone interested, I really do appreciate if someone could guide me through setting it up. There are also tests to correct, since I implemented a new parser and it does some things better (notably #6).

ErKeLost commented 11 months ago

I am very willing to help with your project and I am very interested in it. I will go back and try to migrate github ci for our project first.