search

phoenixframework / esbuild

An installer for esbuild
MIT License
271 stars 38 forks source link

Update Esbuild Version to 0.14.29 #48

Closed kinson closed 2 years ago

kinson commented 2 years ago

Overview

I was taking a look at #38 and noticed the the esbuild version has not been incremented since 0.14.0. I put this pr together quickly in case it would be beneficial to update the latest esbuild version to 0.14.29.

josevalim commented 2 years ago

Thank you! I will merge this but note those numbers have to be updated on Phoenix mix phx.new too (and perhaps updating on Phoenix is the most important!). :)

josevalim commented 2 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

kinson commented 2 years ago

@josevalim Thanks for the heads up, I put together a quick branch with these changes on the Phoenix project.

Before I create a pr I want to walk through the new project setup and makes sure esbuild works with this update as expected and the guides are still up to date.

However, if there are other changes that I missed in this branch (and you have a spare moment to check), let me know: https://github.com/phoenixframework/phoenix/compare/master...kinson:master !

❤️‍🔥 ❤️‍🔥 ❤️‍🔥

josevalim commented 2 years ago

That looks good to me! Please PR and cc me once you are ready!