search

phoenixframework / esbuild

An installer for esbuild
MIT License
271 stars 38 forks source link

Freeze when calling esbuild with default profile when it doesnt exist #49

Closed philipgiuliani closed 2 years ago

philipgiuliani commented 2 years ago

Steps to reproduce

  1. Configure esbuild without the default profile (just rename it to frontend for example)
  2. Run mix esbuild default

Expected Command fails with ** (ArgumentError) unknown esbuild profile. Make sure the profile is defined in your config/config.exs file, such as:...

Actual Command never returns

This is only reproducible with the default profile. When using other profile names, the error message appears correctly.

philipgiuliani commented 2 years ago

Just noticed that a maybe related pull request is already open: https://github.com/phoenixframework/esbuild/pull/47

josevalim commented 2 years ago

If you can look into the PR and fix the build it would be very welcome!

dustessavdh commented 1 month ago

Hi, I recently experienced this bug again. I had renamed the default profile to something else, but didn't update the esbuild default --minify task. It will never return in this case. I'm going to try to make a better analysis, but maybe this issue is still present. This happened when using 0.8.1 of the esbuild package.