search

phoenixframework / esbuild

An installer for esbuild
MIT License
271 stars 38 forks source link

Move esbuild to the NPM @esbuild scope #53

Closed cw789 closed 1 year ago

cw789 commented 2 years ago

This is my take on https://github.com/phoenixframework/esbuild/issues/52. It's not ready until the new breaking version number of esbuild is known for sure.

Update: Ready now → esbuild v0.16.0

josevalim commented 2 years ago

Looks great! A couple notes:

  1. Let's bump the esbuild version once the release is out
  2. Let's update the manual install instructions in Esbuild moduledoc :)
cw789 commented 2 years ago
  1. Totally agree - will do
  2. Good point - will do

Found one more issue with my solution. target() is used in bin_path() → https://github.com/phoenixframework/esbuild/blob/main/lib/esbuild.ex#L128 Means nearly everyone needs to reinstall via mix esbuild.install...

I could additionally do a Version.compare/2 in bin_path() or one in target() and move legacy targets to the target() function.

josevalim commented 2 years ago

Means nearly everyone needs to reinstall via mix esbuild.install...

Well, they will have to reinstall once they change the version or update this package with a new version, so that's ok. :)

cw789 commented 2 years ago

Right, sounds good. Thank you.

chrismccord commented 1 year ago

❤️❤️❤️🐥🔥