phoenixframework / phoenix

Peace of mind from prototype to production
https://www.phoenixframework.org
MIT License
21.45k stars 2.88k forks source link

Fix `CoreComponents` margin between inputs and labels #5884

Open NTurchi opened 3 months ago

NTurchi commented 3 months ago

Description

This is a minor issue with the input component from the core_components.ex file (used in phx.gen.live) A margin top is added by default on inputs for the spacing between the label and the input.

However it is not removed if a label is not provided. Which causes alignment issue when combining the input component with other elements.

As suggested by José Valim, putting the margin on the label itself is more appropriate.

Changes

Closes #5832

before: margin on the input after: margin on the label
image demo