Closed ponychicken closed 5 hours ago
Thank you, @ponychicken! I think we'll need to add web_console_logger: true
here as well:
config :my_app, MyAppWeb.Endpoint,
live_reload: [
+ web_console_logger: true,
patterns: [
~r"priv/static/.*(js|css|png|jpeg|jpg|gif|svg)$",
~r"priv/gettext/.*(po)$",
~r"lib/my_app_web/(controllers|live|components)/.*(ex|heex)$"
]
]
@SteffenDE I think you meant the file installer/templates/phx_umbrella/apps/app_name_web/config/dev.exs right?
I pushed it.
Thank you! 🙌
You had to revert it? Any particular reason?
I didn't see https://github.com/phoenixframework/phoenix/pull/5799 which also added a comment for the click to open functionality, so I went with that one instead.
Should we have it enabled by default in dev?
It is probably the better developer experience, so yeah, I think I'd be happy with doing it by default. I can send a PR :)
This article describes a new and useful feature in Live reload 1.5 and later. I think it could make sense to enable it by default for new projects...
https://fly.io/phoenix-files/phoenix-dev-blog-server-logs-in-the-browser-console/