Use aria-live="polite" for flash_groups

phoenixframework / phoenix

Peace of mind from prototype to production

https://www.phoenixframework.org

MIT License

21.45k stars 2.88k forks source link

Use aria-live="polite" for flash_groups #5920

Open mattmatters opened 2 months ago

mattmatters commented 2 months ago

This nicely notifies screen readers and such of changed content/alerts.

See aria-live for more info.

I've seen some folks use assertive instead of polite for the aria-live setting in a flash/toast context. I'm unsure if there is a defacto one to use in this case though. Open to feedback!

ponychicken commented 1 month ago

I think for most cases "polite" seems like a reasonable choice. In any case, its part of CoreComponents, so if users desire they can easily alter the default.