phoenixframework / phoenix

Peace of mind from prototype to production
https://www.phoenixframework.org
MIT License
21.35k stars 2.87k forks source link

Extract phoenix_redis_pubsub to a separate project #645

Closed josevalim closed 9 years ago

josevalim commented 9 years ago

We should do it when we are closer to 1.0 and push whatever redis dependency (eredis or redo) to hex.

janjiss commented 9 years ago

@josevalim FYI, I tried to gut this out from main Phoenix repo and it was as simple as creating new mix project and putting all files in there. Ping me if you need any help with thing when it is time to do so. https://github.com/janjiss/phoenix_pubsub And all the tests are passing: https://gist.github.com/janjiss/7fe13483c35f67157953

josevalim commented 9 years ago

Awesome @janjiss! We have no plans for doing it now because there will still be development in this area and having multiple projects will slow us down. But help will be welcome once we decide to go this path!

janjiss commented 9 years ago

@josevalim Of course, that makes sense.