Support string fields in input_changed?/3

phoenixframework / phoenix_html

Building blocks for working with HTML in Phoenix

MIT License

403 stars 220 forks source link

Support string fields in input_changed?/3 #428

Closed dvic closed 1 year ago

dvic commented 1 year ago

Closes #427

dvic commented 1 year ago

@josevalim should I also change the typespec of errors in Form? Currently it's errors: Keyword.t() but technically that should be [{atom() | String.t(), term()}]?

josevalim commented 1 year ago

Yes, please.

dvic commented 1 year ago

Yes, please.

Done!

josevalim commented 1 year ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: