Closed alexcastano closed 1 year ago
On #343 we determined we would accept a PR for dark mode, but I think that's it :)
On #343 we determined we would accept a PR for dark mode, but I think that's it :)
Yeah, I see. However, this was before having a real component system. Now it should be easier. 😅
I know José doesn't want to make this project very complex, and I absolutely understand, but I see massive potential if we allow the community more customization with themes and plugins.
Baby steps! It will be an awesome project anyway :)
I think there are two topics here:
My $.02: I don't see the benefit in supporting themes given the complexity they require. Any feature or design modification we do will break themes. So we would either: reach v1.0 and then be unable to improve features, as they would break themes, or release a feature that can break on every new release.
However, I do agree with making it public that we use Bootstrap, allow custom css, and have that as the building block for new pages.
I saw several plus points:
As you rightly point out, backward compatibility is a requirement for the project in the long term, and custom themes will break it. I didn't realize. Considering the pros and cons, it is better not to give theme support. We can solve future features with different approaches.
Thank you
I created #405 to track the docs changes. I am going to work on docs later this afternoon so if it is still open at that time then I will take it :)
Also I am closing this since we are not planning to step up to themes support. Thank you @alexcastano for all of the thoughtful conversation!
Now that we have real components in Dashboard I think we can support themes "easily":
Theme
behaviour with all the components we use. It would be a little bit more complex than simple behaviour because it should have support for all the attrs and slots we use, but it will work.Theme
module or we just delegate to the configured theme.This is the basic idea. What do you think? Am I missing something relevant?