search

phoenixframework / phoenix_live_dashboard

Realtime dashboard with metrics, request logging, plus storage, OS and VM insights
MIT License
1.99k stars 182 forks source link

Max carrier size column behaviour #415

Closed alexcastano closed 1 year ago

alexcastano commented 1 year ago

In the new "Memory Allocator" page we have the column Max carrier size. We use the max value returned by the BEAM.

image

However, the :observer.start() set the max value since the page is shown (or since the observer started), not from the start of the BEAM. I think we can reproduce the same behaviour by keeping a list of the max value per row, in a similar way we do to calculate the reductions:

https://github.com/phoenixframework/phoenix_live_dashboard/blob/da3272dd4404981666fe2c433767fa7d9bff70ba/lib/phoenix/live_dashboard/system_info.ex#L47-L57

The question is, do we want that behavior? Or do we want an extra column?

josevalim commented 1 year ago

I think following observer is the saner choice as they probably thought more and have more context than us. :)