search

phoenixframework / phoenix_live_dashboard

Realtime dashboard with metrics, request logging, plus storage, OS and VM insights
MIT License
2.02k stars 184 forks source link

Rename deprecated `push_redirect` to `push_navigate` #444

Closed joshprice closed 4 months ago

joshprice commented 4 months ago

Removes the following compile time deprecation warnings:

==> phoenix_live_dashboard
Compiling 36 files (.ex)
    warning: Phoenix.LiveView.push_redirect/2 is deprecated. Use push_navigate/2 instead
    │
 21 │         {:ok, push_redirect(socket, to: to)}
    │               ~
    │
    └─ lib/phoenix/live_dashboard/pages/metrics_page.ex:21:15: Phoenix.LiveDashboard.MetricsPage.mount/3
    └─ lib/phoenix/live_dashboard/pages/metrics_page.ex:30:15: Phoenix.LiveDashboard.MetricsPage.mount/3

    warning: Phoenix.LiveView.push_redirect/2 is deprecated. Use push_navigate/2 instead
    │
 41 │     {:ok, push_redirect(socket, to: to)}
    │           ~
    │
    └─ lib/phoenix/live_dashboard/pages/request_logger_page.ex:41:11: Phoenix.LiveDashboard.RequestLoggerPage.mount/3

Upgrade some deps
     warning: Phoenix.LiveView.push_redirect/2 is deprecated. Use push_navigate/2 instead
     │
 291 │       {:noreply, push_redirect(socket, to: to)}
     │                  ~
     │
     └─ lib/phoenix/live_dashboard/page_live.ex:291:18: Phoenix.LiveDashboard.PageLive.handle_event/3
     └─ lib/phoenix/live_dashboard/page_live.ex:369:5: Phoenix.LiveDashboard.PageLive.redirect_to_current_node/1
josevalim commented 4 months ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: