phoenixframework / phoenix_live_reload

Provides live-reload functionality for Phoenix
MIT License
317 stars 90 forks source link

Add test to check if the plug works with iolists #103

Closed hauleth closed 4 years ago

hauleth commented 4 years ago

This uses complex iolist that should be handled properly according to the Plug.Conn and Phoenix.LiveReloader documentation.

hauleth commented 4 years ago

This is the result of #102 and unintentional bug caused after proposed changes. This test should prevent such things from happening in the future.

josevalim commented 4 years ago

Fantastic idea! Thank you.

josevalim commented 4 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: