search

phoenixframework / phoenix_live_reload

Provides live-reload functionality for Phoenix
MIT License
317 stars 90 forks source link

Fix compilation warnings on newest Elixir #138

Closed crbelaus closed 1 year ago

crbelaus commented 1 year ago

When compiling this project with Elixir 1.15 we get two warnings:

  1. use Mix.Config is deprecated. Use the Config module instead. Deprecated since Elixir 1.9
  2. Logger.warn/1 is deprecated. Use Logger.warning/2 instead. Deprecated since Elixir 1.15

This pull request fixes both deprecation warnings and bumps the minimum required Elixir version to 1.11 to ensure that the non-deprecated alternatives are supported. Otherwise we would have to use different code depending on the Elixir version.

Bumping the required Elixir version to 1.11 is a breaking change but was discussed in phoenixframework/phoenix_live_reload#137.

josevalim commented 1 year ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart: