search

phoenixframework / phoenix_live_reload

Provides live-reload functionality for Phoenix
MIT License
317 stars 90 forks source link

Add web console logger and open file from client support #147

Closed chrismccord closed 9 months ago

chrismccord commented 9 months ago

Umbrellas and deps now supported // @josevalim

frankdugan3 commented 9 months ago

Just a thought, maybe it would be preferable to more tightly namespace PLUG_EDITOR to something like PHX_PLUG_EDITOR. Personally, I'd probably set this in my .profile, so it would be good to ensure it doesn't clash with other projects. PLUG is a generic enough word that it may be used by something else.

If that sounds too much like bikeshedding, feel free to ignore. :grin:

chrismccord commented 9 months ago

PLUG_EDITOR is existing "standard" for the plug debugger page (which is used by phoenix), so we'd need to change it there, but I don't know that the churn is worth it