Improvements to Phoenix.LiveView.JS docs

phoenixframework / phoenix_live_view

Rich, real-time user experiences with server-rendered HTML

https://hex.pm/packages/phoenix_live_view

MIT License

6k stars 906 forks source link

Improvements to Phoenix.LiveView.JS docs #3267

Closed rhcarvalho closed 1 month ago

rhcarvalho commented 1 month ago

Like in the other "toggles" in this file, explicitly mention that classes may be added or removed based on presence.

rhcarvalho commented 1 month ago

@SteffenDE thanks for the review. I've rebased against latest main (no conflicts and no changes to my original commit), and applied the suggestions revising the file/module as a whole as a new commit.

SteffenDE commented 1 month ago

lgtm. Let's maybe get some feedback from @chrismccord as well as he wrote most of the docs for the JS module.

chrismccord commented 1 month ago

❤️❤️❤️🐥🔥