phoenixframework / phoenix_live_view

Rich, real-time user experiences with server-rendered HTML
https://hex.pm/packages/phoenix_live_view
MIT License
6.14k stars 919 forks source link

revert: Consider all refs as skip #3308

Closed SteffenDE closed 3 months ago

SteffenDE commented 3 months ago

Reverts https://github.com/phoenixframework/phoenix_live_view/commit/2785f5bb2df6eb2863567e3c9da622b4499968fc.

The change introduced in the commit causes elements that have been skipped to be patched on undoRefs without handling special cases like phx-update, nested LiveViews, Streams, etc.

This wasn't an issue in the past because the only elements patched that way were inputs, and they don't contain other nodes.

It probably makes sense to work on the refs skipping in https://github.com/phoenixframework/phoenix_live_view/pull/3307.

chrismccord commented 3 months ago

❤️❤️❤️🐥🔥