Wrong version in built JS - Githubissues

phoenixframework / phoenix_live_view

Rich, real-time user experiences with server-rendered HTML

https://hex.pm/packages/phoenix_live_view

MIT License

6.14k stars 919 forks source link

Wrong version in built JS #3318

Closed tmjoen closed 3 months ago

tmjoen commented 3 months ago

Environment

Elixir version (elixir -v):
Phoenix version (mix deps):
Phoenix LiveView version (mix deps): 1.0.0-rc.4
Operating system:
Browsers you attempted to reproduce this bug on (the more the merrier):
Does the problem persist after removing "assets/node_modules" and trying again? Yes/no:

Actual behavior

No big deal of course, but RC 4 still has RC 3 as the version in the built JS:

https://github.com/phoenixframework/phoenix_live_view/blob/main/priv/static/phoenix_live_view.esm.js#L4088

which leads to this warning:

chrismccord commented 3 months ago

Fixed with rc.5. Thanks!