do not emit change event while inside composition

phoenixframework / phoenix_live_view

Rich, real-time user experiences with server-rendered HTML

https://hex.pm/packages/phoenix_live_view

MIT License

5.99k stars 902 forks source link

do not emit change event while inside composition #3332

Open SteffenDE opened 5 days ago

SteffenDE commented 5 days ago

Safari breaks character composition mode if an input is patched while a composition is in progress. This commit works around this by ignoring input events that are triggered while a composition is in progress and emitting the event only after the composition is finished.

Fixes https://github.com/phoenixframework/phoenix_live_view/issues/3322.

woylie commented 5 days ago

I tested this in Safari, Chrome, and Firefox on macOS, and everything seems to work fine now. Thank you!