phoenixframework / phoenix_pubsub_redis

The Redis PubSub adapter for the Phoenix framework
175 stars 66 forks source link

Redis disconnections not being handled by RedisServer #29

Closed robmadole closed 6 years ago

robmadole commented 7 years ago

I am running 2.1.3 which includes the handle_info method that should take care of this but it's still showing up in our logs. I've double-checked that we are running 2.1.3.

The exception from Sentry is:

  File "lib/phoenix_pubsub_redis/redis_server.ex", line 62, in Phoenix.PubSub.RedisServer.handle_info({:redix_pubsub, #PID<0.303.0>, :disconnected, %{reason: :tcp_closed}}, %{namespace: "phx:Elixir.FontawesomeCdn.PubSub", node_ref: <<22, 140, 43, 140, 32, 47, 230, 136, 189, 12, 123, 20, 77, 8, 114, 84, 1, 252, 250,...
  File "gen_server.erl", line 601, in :gen_server.try_dispatch/4
  File "gen_server.erl", line 667, in :gen_server.handle_msg/5
  File "proc_lib.erl", line 247, in :proc_lib.init_p_do_apply/3

I wish that I had the entire exception because that would shed a little more light on why this is still occurring.

robmadole commented 7 years ago

I'll try and reproduce this and get a better exception later today. That would help a ton.

chrismccord commented 7 years ago

Yes a full stack trace would definitely be helpful. Thanks!

mitchellhenke commented 6 years ago

I'm going to close this for inactivity, though I'd be happy to revisit if there is more information 🙂

robmadole commented 6 years ago

Yeah we didn’t see it again. 🤷‍♂️ Thanks @mitchellhenke

mitchellhenke commented 6 years ago

@robmadole cool, thanks for letting me know!