search

phoenixframework / phoenix_pubsub_redis

The Redis PubSub adapter for the Phoenix framework
175 stars 66 forks source link

Update to redix 0.9 #35

Closed bernardd closed 5 years ago

bernardd commented 5 years ago

Redix 0.9 rolls redix_pubsub into the main app, so it can be dropped as a dependency.

mitchellhenke commented 5 years ago

Thanks for opening this!

It seems like the tests are failing with this update? I am currently planning on taking a look into it at the end of the week if you don't get a chance to by then 🙂

bernardd commented 5 years ago

They're passing for me locally. What failures are you seeing?

mitchellhenke commented 5 years ago

For me, all of the tests fail with some variation of:

     ** (EXIT from #PID<0.515.0>) shutdown: failed to start child: Phoenix.PubSub.RedisServer
         ** (EXIT) an exception was raised:
             ** (FunctionClauseError) no function clause matching in Redix.PubSub.start_link/2
                 (redix) lib/redix/pubsub.ex:344: Redix.PubSub.start_link([host: "127.0.0.1", port: 6379], [sync_connect: true])
                 (phoenix_pubsub_redis) lib/phoenix_pubsub_redis/redis_server.ex:126: Phoenix.PubSub.RedisServer.establish_conn/1
                 (phoenix_pubsub_redis) lib/phoenix_pubsub_redis/redis_server.ex:61: Phoenix.PubSub.RedisServer.init/1
                 (stdlib) gen_server.erl:374: :gen_server.init_it/2
                 (stdlib) gen_server.erl:342: :gen_server.init_it/6
                 (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3
bernardd commented 5 years ago

That's really weird, because the call on redis_server.ex:126 is to Redix.PubSub.start_link/1, not /2 - there's no code path I can see that should be able to land on the /2 version at all.

mitchellhenke commented 5 years ago

@bernardd Ah, there was an issue on my end, sorry for the delay and confusion.

mitchellhenke commented 5 years ago

Released in 2.1.5

bernardd commented 5 years ago

No worries, thanks - happy new year :)