search

phoenixframework / phoenix_pubsub_redis

The Redis PubSub adapter for the Phoenix framework
175 stars 66 forks source link

Redis config does not accept the SSL option #37

Closed dpick closed 5 years ago

dpick commented 5 years ago

Redix has an ssl: true option so it can connect to a Redis via an encrypted connection. It looks like the Phoenix.PubSub.Redis adapter ignores that option right now :( via this take - https://github.com/phoenixframework/phoenix_pubsub_redis/blob/master/lib/phoenix_pubsub_redis/redis.ex#L58.

If I get some time this week I'll try to send a PR, but for now I'm just opening an issue so people are aware.

mitchellhenke commented 5 years ago

@dpick thanks for opening this!

If you don't find the time, I should be able to get to it by the end of the week.

dpick commented 5 years ago

Awesome, thanks for the very quick response @mitchellhenke!

mitchellhenke commented 5 years ago

I opened #38 if you want to give it a shot. It seems to work as expected from my testing, and I'll likely come back and merge/release by the end of the week barring any issues.

dpick commented 5 years ago

It looks good to me, thanks!

mitchellhenke commented 5 years ago

This has been released in 2.1.6