search

phoenixframework / phoenix_pubsub_redis

The Redis PubSub adapter for the Phoenix framework
175 stars 66 forks source link

Allow 'rediss' URL scheme to define whether SSL is enabled #58

Open tomtaylor opened 3 years ago

tomtaylor commented 3 years ago

We use the REDIS_URL env var on Heroku to define our Redis URL. When SSL is enabled this is indicated by the rediss scheme in the URL.

As it stands, phoenix_pubsub_redis ignores this, and forces us to set ssl: true to use SSL for the connection.

This change allows the URL scheme to define whether SSL is enabled, removing the need to keep the :ssl setting inline with the URL scheme.

tomtaylor commented 3 years ago

@chrismccord any thoughts on this?

gorkunov commented 3 years ago

we are also experiencing this issue.