phoenixframework / phoenix_pubsub_redis

The Redis PubSub adapter for the Phoenix framework
175 stars 66 forks source link

Unable to use sentinel config #62

Open seninm01 opened 1 year ago

seninm01 commented 1 year ago

Because of @default using 127.0.0.1 host and default port, when using sentinel it always barfs here:

redix/lib/redix/start_options.ex

Line 84 in 81a2e85 raise ArgumentError, ":host or :port can't be passed as option if :sentinel is used"

Need to be careful with https://github.com/phoenixframework/phoenix_pubsub_redis/blob/028cd1689c21969a860d934fe6aa5b24fa46e2be/lib/phoenix_pubsub_redis/redis.ex#L71 because host and port are already present in the defaults and Redix won't allow sentinel config to also be supplied in this case.