Hello, love this project and excited to see it continue <3
In assets/js/app.js line 3 is removed but not lines 1 and 2 which pertain to it:
// We import the CSS which is extracted to its own file by esbuild.
// Remove this line if you add a your own CSS build pipeline (e.g postcss).
import "../css/app.css"
I'm suggesting removing lines 1 & 2 as well because it would be confusing in the future to come across those comments having forgotten you already did "remove this line". This file augmentation code is already being tested, so a PR could add those as well.
Alternatively, you could comment out line 3 instead of deleting it. In that case, there is a grammatical error on line 2 which could be PR'd as well.
I'm happy to submit a PR for any of this when I get a chance, but also happy to have someone else do the work 😉 if it's deemed a worthy change. Thanks! :D
Hello, love this project and excited to see it continue <3
In
assets/js/app.jsline 3 is removed but not lines 1 and 2 which pertain to it:I'm suggesting removing lines 1 & 2 as well because it would be confusing in the future to come across those comments having forgotten you already did "remove this line". This file augmentation code is already being tested, so a PR could add those as well.
Alternatively, you could comment out line 3 instead of deleting it. In that case, there is a grammatical error on line 2 which could be PR'd as well.
I'm happy to submit a PR for any of this when I get a chance, but also happy to have someone else do the work 😉 if it's deemed a worthy change. Thanks! :D