search

phoenixframework / tailwind

An installer for tailwind
MIT License
475 stars 61 forks source link

Confusion around expected behavior from a phx.new project and phoenix.css #28

Open aegatlin opened 2 years ago

aegatlin commented 2 years ago

Hello, love this project and looking forward to its future <3

I have setup tailwind successfully using the README instructions but the default phx.new page CSS is broken. I suspect this is because the CSS from phoenix.css is missing. This makes sense given the changes being made, but I've spent a few hours now assuming I had done something wrong because the homepage CSS was not what I was expecting.

I can't tell if I have done something wrong.

(A) If I have done something wrong: I can't figure out how to keep the phoenix.css CSS around within the setup process.

(B) If I have not done something wrong: I suggest there be a note in the README telling me to expect the home page CSS to be messed up, since the phoenix.css CSS is now missing. And perhaps also recommend me to delete the phoenix.css file (or something like that).

oskarkook commented 2 years ago

Coincidentally, I have a PR for this, which would leave a comment in the CSS file instead of deleting the import: https://github.com/phoenixframework/tailwind/pull/26/files#diff-1fa157207e3c87759b3d08b515a3a3b901f031919ecae8c487214d51578a7447R74-R79

Not that it's the best solution to this, but just one option :)

aegatlin commented 2 years ago

Glad to see I'm not crazy in failing to import phoenix.css XD. I also came across this blog post by Chris mentioning they will bring this in to phx.new eventually, so maybe they are ignoring phoenix.css because they are going to completly remove it from future generators. 🤷

https://fly.io/phoenix-files/tailwind-standalone/