Closed aptinio closed 5 months ago
I don't think it's necessary since Elixir 1.11 is required:
and Logger.warning/2
has been available since Elixir 1.11.
Agreed, this shouldn't be blocking as it's been available since 1.11, but the way to check would be macro_exported?(Logger, :warning, 2)
Agreed, this shouldn't be blocking as it's been available since 1.11, but the way to check would be
macro_exported?(Logger, :warning, 2)
Ideally GitHub Actions running tests against latest and older elixir version would confirm that here in PR checks, but the tests aren't running for this repo since the default branch was changed to main
.
Fixed in https://github.com/phoenixframework/tailwind/pull/93.
@chrismccord is there anything we can do to help get these merged? 🙏🏻 Politely asking because I am seeing lots of these in a (mostly brand new) Phoenix app and would like to help reduce the warnings emitted on a fresh phoenix install.
The fix is already in master: https://github.com/phoenixframework/tailwind/commit/3295cf81eede615e31a4858f6a00a4c39a7d5101
Close?
I wonder what approach to backward Elixir compatibility should be used here.