phoenixframework / vscode-phoenix

Syntax highlighting support for Phoenix templates in Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=phoenixframework.phoenix
MIT License
160 stars 10 forks source link

Fix syntax highlighting in comments #16

Closed basilenouvellet closed 2 years ago

basilenouvellet commented 2 years ago

Problem

Syntax highlighting does not work:

  1. for new comments syntax <%!-- ... --%>
  2. for comments syntax <% # ... %>, which is highlighted as embedded elixir instead of heex comment

comments_syntax_issue.webm

See https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.HTMLFormatter.html#module-inline-comments-comment.

Solution

comments_syntax_issue_solved.webm

chrismccord commented 2 years ago

Thank you so much for these! ❤️❤️❤️🐥🔥

basilenouvellet commented 2 years ago

You're very welcome, thank you for your hard work!

chrismccord commented 2 years ago

I just published 0.1.2 with your features! Thanks!