Allow multiple ResponseGroups for a single request to be specified as an Array

phoet / asin

:books: :package: Amazon Simple INterface - Support for ItemLookup, SimilarityLookup, Search, BrowseNode and Cart Operations

http://asin.herokuapp.com/

167 stars 59 forks source link

Allow multiple ResponseGroups for a single request to be specified as an Array #10

Closed bprotas closed 13 years ago

bprotas commented 13 years ago

It seemed natural to me to specify multiple ResponseGroups like:

lookup "1430218150", :ResponseGroup => [:Small, :AlternateVersions]

This small patch checks if ResponseGroup is an array, and if it is, joins it and sends on to Amazon. Test case included.

phoet commented 13 years ago

hi bprotas, i will have a look into this within the next week.

phoet commented 13 years ago

hi ben,

i generalized your approach, so that it's possible to pass in an array as value paramter. even though i don't think it's appropriate for other parameters :)

if you think this is an ok version i will push 0.6.2 within the next days.

kind regards, peter

bprotas commented 13 years ago

That's awesome! Thanks!

phoet commented 13 years ago

just ping me if you think it works as expected and i will push a new version