search

phoet / asin

:books: :package: Amazon Simple INterface - Support for ItemLookup, SimilarityLookup, Search, BrowseNode and Cart Operations
http://asin.herokuapp.com/
167 stars 59 forks source link

Adding helper method for remote cart operations #3

Closed rehanift closed 13 years ago

rehanift commented 13 years ago

Hello Phoet

I have added remote cart operations to the ASIN gem. Would you like to include this with branch?

-Rehan

phoet commented 13 years ago

oh, i just saw the last commit and not all the other changes :)

i will have a look at how to integrate it withouth sacrificing the simpicity of asin

phoet commented 13 years ago

i just added some basic functionality the way that i see this implemented:

https://github.com/phoet/asin/commit/585569f372c2907e06f16e0151d07efc251dbe92

hopefully i will get it done on the weekend.

phoet commented 13 years ago

i think i have found a nice way of integrating this. will be done within the next days

phoet commented 13 years ago

could you please have another look at the latest commits?

i think it should work as far as i anderstand the api.

rehanift commented 13 years ago

Your changes look really clean. I like how your wrapped the response in a Cart object.

I will test this out later today to make sure things work as expected. Do you want me to write up documentation for cart operations? or do you already have that?

phoet commented 13 years ago

great you like it.

i would be glad if you test it, because i have not a real understanding of how it should work, as i did not use it in any kind of application jet.

you don't need to add documentation, i will split up the existing docs anyway to separate search from cart logic. i think that i can do it over the weekend.

phoet commented 13 years ago

i finally updated things...

did you do some testing? any feedback?

rehanift commented 13 years ago

I have played around with your changes and everything seems to be working great. I will try and do some integration testing and let you know how it works.

Thank you for your help, it has been most appreciated!

-Rehan

phoet commented 13 years ago

cool! did you see that i already pushed a beta version? https://rubygems.org/gems/asin/versions/0.4.0.beta1

rehanift commented 13 years ago

Awesome. What are your plans for moving out of beta? Community feedback? Testing?

phoet commented 13 years ago

especially your feedback ;)