search

phoet / asin

:books: :package: Amazon Simple INterface - Support for ItemLookup, SimilarityLookup, Search, BrowseNode and Cart Operations
http://asin.herokuapp.com/
167 stars 59 forks source link

updated lookup method in 0.8.0 branch #35

Closed wjgilmore closed 10 years ago

wjgilmore commented 10 years ago

The 2.0 release uses RashieMash and I am for some reason unable to get asin/adapter working in conjunction with the lookup method. For the time being I'll continue using the 0.8.0 branch and so thought I'd contribute this change in case other users still on this branch were interested. The addition makes it possible to use the lookup method in conjunction with the ISBN IdType, meaning users can query Amazon for book ISBNs instead of solely relying on the ASIN. My pull request is supposed to target the 0.8.0 branch specifically; this won't work of course with the 2.0 release.

phoet commented 10 years ago

@wjgilmore thx for pointing this out. what exactly are the issues with the 2.x release? can you show some code or an example to reproduce it? what version of ruby are you running on?