search

phoet / asin

:books: :package: Amazon Simple INterface - Support for ItemLookup, SimilarityLookup, Search, BrowseNode and Cart Operations
http://asin.herokuapp.com/
167 stars 59 forks source link

Hashie::Rash namespace collision in newer versions of Hashie & Rash gems #45

Closed corprew closed 8 years ago

corprew commented 8 years ago

Hi.

In the current version of Hashie, Rash is used for a regular expression-based hash, and the Rash gem's definitions of Rash gets overridden by the Hashie Gem's own. wzcolon has forked the gem to use a new namespace for the class. (Hashie::Hash::Rash, see https://github.com/wzcolon/rash.)

Would you accept a pull request to point at the new version of Rash? The tests currently pass but moving forward to the current version of Hashie is required for some other products.

phoet commented 8 years ago

Yes, please go ahead with the PR

Corprew Reed notifications@github.com schrieb am Mo., 8. Feb. 2016, 04:21:

Hi.

In the current version of Hashie, Rash is used for a regular expression-based hash, and the Rash gem's definitions of Rash gets overridden by the Hashie Gem's own. wzcolon has forked the gem to use a new namespace for the class. (Hashie::Hash::Rash, see https://github.com/wzcolon/rash.)

Would you accept a pull request to point at the new version of Rash? The tests currently pass but moving forward to the current version of Hashie is required for some other products.

— Reply to this email directly or view it on GitHub https://github.com/phoet/asin/issues/45.

corprew commented 8 years ago

https://github.com/phoet/asin/pull/46