search

phoible / dev

PHOIBLE data and development.
https://phoible.org/
GNU General Public License v3.0
121 stars 30 forks source link

Mako inventory by Brynna #283

Closed bnk7 closed 4 years ago

bnk7 commented 4 years ago

closes #118

bnk7 commented 4 years ago

Yay, thanks! I fixed the formatting issues.

drammock commented 4 years ago

@bnk7 also take note at how I edited the "description" field at the top of this PR. The special text closes #118 is recognized as a "hook" by GitHub, and when this PR gets merged, the linked issue will automatically get closed. When you're making future PRs that address a particular issue, you can use that trick.

bnk7 commented 4 years ago

I don't know why it got rid of all the quotation marks. Trying to fix that

bnk7 commented 4 years ago

@bnk7 the inventory looks great. I've made two "suggestions" on the BibTeX file through the GitHub UI, so you can see what that looks like. Please go to the "Files changed" tab you can add them all as a batch, and then commit the changes directly on the website.

NOTE: this will add a commit on your remote fork, which will be missing from your local clone. Be sure to pull down the changes before doing anything else locally, or else your local clone and remote fork will get out of sync.

I keep getting this error: "This diff has recently been updated. Please refresh and try again." I'm not sure what it means, and refreshing doesn't work. Any suggestions?

drammock commented 4 years ago

I keep getting this error: "This diff has recently been updated. Please refresh and try again." I'm not sure what it means, and refreshing doesn't work. Any suggestions?

Hmm, that's a new one for me. Here's what I see if I try to add to batch:

Screenshot_2020-06-29_13-04-10

Do you get that error only after clicking "commit changes"? Or earlier than that?

bnk7 commented 4 years ago

I got it only after clicking "commit changes". I got the same message when I tried committing them individually.

drammock commented 4 years ago

I got it only after clicking "commit changes". I got the same message when I tried committing them individually.

I can't get it to work either, I get the same error you do in the same circumstances.

drammock commented 4 years ago

Dear GitHub support: here's a screenshot of what we were dealing with

Screenshot_2020-06-29_13-47-11

drammock commented 4 years ago

@bnk7 I guess for now can you implement my suggested changes in a new local commit and push it here? I don't want to wait around to merge this until GH support answers/fixes this problem.

bnk7 commented 4 years ago

Sounds good