search

phoible / dev

PHOIBLE data and development.
https://phoible.org/
GNU General Public License v3.0
115 stars 30 forks source link

Fix EA breathy #347

Closed drammock closed 2 years ago

drammock commented 2 years ago

closes #346

Also actually addresses #192 (though perhaps not completely; I didn't check every line), unlike #198 which auto-closed #192 when it probably shouldn't have.

Also adds a couple more tests: one to make sure feature vector assignment is consistent (e.g., [h] always has the same features across all inventories) and to look for non-distinct feature vectors within an inventory. That latter test is expected to fail, but it will make it way easier to fix the problems once that test is in place.

bambooforest commented 2 years ago

Problem of duplicated feature vectors also noted in #352