search

phoible / dev

PHOIBLE data and development.
https://phoible.org/
GNU General Public License v3.0
115 stars 30 forks source link

Segment fixes for 1284 and 1927 as found by the DR algorithm #356

Closed bambooforest closed 1 year ago

bambooforest commented 1 year ago

This PR fixes a mistake in Inventory ID 1284 (Mada):

https://phoible.org/inventories/view/1284

and changes eʲ to e (as per the grammar) in the raw data file:

https://github.com/phoible/dev/blob/master/raw-data/PH/gm-afr-inventories.tsv#L1977-L1978

This PR also fixes segments in Inventory ID 1927 (Mỹky):

https://phoible.org/inventories/view/1927

originally from SAPHON source, raw data file:

https://github.com/phoible/dev/blob/master/raw-data/SAPHON/saphon20121031.tsv#L129

and removes the segments (õʲ, aʲ, oʲ) as they do not appear in the original source:

https://linguistics.berkeley.edu/saphon/en/inv/Irantxe.html

bambooforest commented 1 year ago

@drammock -- had to merge in your previous PR (#358) and regen the phoible csv file.

drammock commented 1 year ago

ok. Just a heads up to (usually) not do that with open PRs. In this case (merged PR) it should be fine, though in this case it's equivalent to merging in main (which is pretty much always OK/good to do if your PR branch is behind main).

Is this ready for merge then?

bambooforest commented 1 year ago

Thanks for the heads up. Yes, it's ready to go.