phoinixi / jsonresume-theme-stackoverflow

Stack Overflow theme for JSON Resume
https://francesco.netlify.app/
133 stars 134 forks source link

adding missing main and removing dev dep as it causes resume to fail #25

Closed chasebolt closed 6 years ago

chasebolt commented 6 years ago

currently i have to install require-dir in order to get this theme to work with resume. removing the devDependencies fixes the theme.

# resume export --theme stackoverflow resume.html

  running validation tests on resume.json ... 

  ✓ Passed all validation tests. 

To publish your resume at http://jsonresume.org type the command resume publish
You have to install this theme globally to use it e.g. `npm install -g jsonresume-theme-stackoverflow`

here is an example Dockerfile showing the error if you try and make a resume

FROM alpine:latest

RUN apk --no-cache add \
      nodejs-npm \
    && npm install -g \
         resume-cli \
         jsonresume-theme-stackoverflow

ENTRYPOINT ["resume"]
phoinixi commented 6 years ago

Thank you! I changed loading method of the helpers and removed require-dir from dependency from the code