phoinixi / jsonresume-theme-stackoverflow

Stack Overflow theme for JSON Resume
https://francesco.netlify.app/
133 stars 134 forks source link

Incorrect html rendering of dates for several awards, publications. #30

Closed rstuckey closed 5 years ago

rstuckey commented 6 years ago

Hi,

Thanks for the great theme, I really like it. There is a problem with the html generated when there are several awards, or publications though. Please see the screenshot attached. The pdf looks fine (also attached).

I use hackmyresume as follows:

$ hackmyresume BUILD resume-test.json TO resume-test.pdf -t jsonresume-theme-stackoverflow --pdf wkhtmltopdf

My apologies if this is an error with hackmyresume and not your theme.

Regards, Roger

{
  "basics": {
    "name": "Richard Hendriks",
    "label": "Programmer",
    "picture": "",
    "email": "richard.hendriks@gmail.com",
    "phone": "(912) 555-4321",
    "website": "https://richardhendricks.com",
    "summary": "Richard hails from Tulsa. He has earned degrees from the University of Oklahoma and Stanford. (Go Sooners and Cardinal!) Before starting Pied Piper, he worked for Hooli as a part time software developer. While his work focuses on applied information theory, mostly optimizing lossless compression schema of both the length-limited and adaptive variants, his non-work interests range widely, everything from quantum computing to chaos theory. He could tell you about it, but THAT would NOT be a “length-limited” conversation!",
    "location": {
      "address": "2712 Broadway St",
      "postalCode": "CA 94115",
      "city": "San Francisco",
      "countryCode": "US",
      "region": "California"
    },
    "profiles": [
      {
        "network": "Twitter",
        "username": "neutralthoughts",
        "url": ""
      },
      {
        "network": "SoundCloud",
        "username": "dandymusicnl",
        "url": "https://soundcloud.com/dandymusicnl"
      }
    ]
  },
  "work": [
    {
      "company": "Pied Piper",
      "position": "CEO/President",
      "website": "https://piedpiper.com",
      "startDate": "2013-12-01",
      "endDate": "2014-12-01",
      "summary": "Pied Piper is a multi-platform technology based on a proprietary universal compression algorithm that has consistently fielded high Weisman Scores™ that are not merely competitive, but approach the theoretical limit of lossless compression.",
      "highlights": [
        "Build an algorithm for artist to detect if their music was violating copy right infringement laws",
        "Successfully won Techcrunch Disrupt",
        "Optimized an algorithm that holds the current world record for Weisman Scores"
      ]
    }
  ],
  "volunteer": [
    {
      "organization": "CoderDojo",
      "position": "Teacher",
      "website": "https://coderdojo.com/",
      "startDate": "2012-01-01",
      "endDate": "2013-01-01",
      "summary": "Global movement of free coding clubs for young people.",
      "highlights": [
        "Awarded 'Teacher of the Month'"
      ]
    },
    {
      "organization": "CoderDojo",
      "position": "Teacher",
      "website": "https://coderdojo.com/",
      "startDate": "2012-01-01",
      "endDate": "2013-01-01",
      "summary": "Global movement of free coding clubs for young people.",
      "highlights": [
        "Awarded 'Teacher of the Month'"
      ]
    }
  ],
  "education": [
    {
      "institution": "University of Oklahoma",
      "area": "Information Technology",
      "studyType": "Bachelor",
      "startDate": "2011-06-01",
      "endDate": "2014-01-01",
      "gpa": "4.0",
      "courses": [
        "DB1101 - Basic SQL",
        "CS2011 - Java Introduction"
      ]
    }
  ],
  "awards": [
    {
      "title": "Digital Compression Pioneer Award",
      "date": "2014-11-01",
      "awarder": "Techcrunch",
      "summary": "There is no spoon."
    },
    {
      "title": "Digital Compression Pioneer Award",
      "date": "2014-11-01",
      "awarder": "Techcrunch",
      "summary": "There is no spoon."
    },
    {
      "title": "Digital Compression Pioneer Award",
      "date": "2014-11-01",
      "awarder": "Techcrunch",
      "summary": "There is no spoon."
    },
    {
      "title": "Digital Compression Pioneer Award",
      "date": "2014-11-01",
      "awarder": "Techcrunch",
      "summary": "There is no spoon."
    },
    {
      "title": "Digital Compression Pioneer Award",
      "date": "2014-11-01",
      "awarder": "Techcrunch",
      "summary": "There is no spoon."
    }
  ],
  "publications": [
    { 
      "name": "Video compression for 3d media",
      "publisher": "Hooli",
      "releaseDate": "2014",
      "website": "https://en.wikipedia.org/wiki/Silicon_Valley_(TV_series)",
      "summary": "."
    },
    {
      "name": "Video compression for 3d media",
      "publisher": "Hooli",
      "releaseDate": "2014",
      "website": "https://en.wikipedia.org/wiki/Silicon_Valley_(TV_series)",
      "summary": "."
    },
    {
      "name": "Video compression for 3d media",
      "publisher": "Hooli",
      "releaseDate": "2014",
      "website": "https://en.wikipedia.org/wiki/Silicon_Valley_(TV_series)",
      "summary": "."
    },
    {
      "name": "Video compression for 3d media",
      "publisher": "Hooli",
      "releaseDate": "2014",
      "website": "https://en.wikipedia.org/wiki/Silicon_Valley_(TV_series)",
      "summary": "."
    },
    {
      "name": "Video compression for 3d media",
      "publisher": "Hooli",
      "releaseDate": "2014",
      "website": "https://en.wikipedia.org/wiki/Silicon_Valley_(TV_series)",
      "summary": "."
    }
  ],
  "skills": [
    {
      "name": "Web Development",
      "level": "Master",
      "keywords": [
        "HTML",
        "CSS",
        "Javascript"
      ]
    },
    {
      "name": "Web Development",
      "level": "Master",
      "keywords": [
        "HTML",
        "CSS",
        "Javascript"
      ]
    },
    {
      "name": "Web Development",
      "level": "Master",
      "keywords": [
        "HTML",
        "CSS",
        "Javascript"
      ]
    },
    {
      "name": "Web Development",
      "level": "Master",
      "keywords": [
        "HTML",
        "CSS",
        "Javascript"
      ]
    },
    {
      "name": "Compression",
      "level": "Master",
      "keywords": [
        "Mpeg",
        "MP4",
        "GIF"
      ]
    }
  ],
    "references": [
    {
      "name": "Erlich Bachman",
      "reference": "It is my pleasure to recommend Richard, his performance working as a consultant for Main St. Company proved that he will be a valuable addition to any company."
    },
    {
      "name": "Erlich Bachman",
      "reference": "It is my pleasure to recommend Richard, his performance working as a consultant for Main St. Company proved that he will be a valuable addition to any company."
    },
    {
      "name": "Erlich Bachman",
      "reference": "It is my pleasure to recommend Richard, his performance working as a consultant for Main St. Company proved that he will be a valuable addition to any company."
    },
    {
      "name": "Erlich Bachman",
      "reference": "It is my pleasure to recommend Richard, his performance working as a consultant for Main St. Company proved that he will be a valuable addition to any company."
    },
    {
      "name": "Erlich Bachman",
      "reference": "It is my pleasure to recommend Richard, his performance working as a consultant for Main St. Company proved that he will be a valuable addition to any company."
    }
  ]
}

resume-test html

resume-test.pdf

felipeamarante commented 6 years ago

PERHAPS this can fix your issue, I hope!

https://github.com/francescoes/jsonresume-theme-stackoverflow/pull/31

felipeamarante commented 6 years ago

Yup, actually fixed!

Check your version with PR code applied : http://cv.felipe.cloud/richard.html

rstuckey commented 6 years ago

Hi @felipeamarante, thanks for that. Your fix corrects the original json rendering above, but if I remove the summary fields from either the awards or publications, the error reappears :(

phoinixi commented 6 years ago

Hi @rstuckey sorry if I didn't handle this yet, I will have a look asap :)

brolaugh commented 5 years ago

What's the progress on this?

phoinixi commented 5 years ago

This is fixed in the last release :)