search

phoinixi / jsonresume-theme-stackoverflow

Stack Overflow theme for JSON Resume
https://francesco.netlify.app/
132 stars 134 forks source link

Should be used image and not picture #36

Closed lfbn closed 5 years ago

lfbn commented 5 years ago

Hi,

According to the JSON schema is image. Shouldn't this be changed from picture? https://github.com/phoinixi/jsonresume-theme-stackoverflow/blob/43adedfc4ad980a5b7a314412a4a32f6568eae7a/theme/partials/basics.hbs#L3

Thanks.

phoinixi commented 5 years ago

Nice catch!

Would you like to contribute and fix it or are you asking for a bug fix?

lfbn commented 5 years ago

I will contribute. Thanks.

lfbn commented 5 years ago

Here it is PR #37 .

phoinixi commented 5 years ago

Thanks for contributing