phoinixi / jsonresume-theme-stackoverflow

Stack Overflow theme for JSON Resume
https://francesco.netlify.app/
132 stars 134 forks source link

Merge levinos updates / upgrades #80

Open levino opened 1 year ago

levino commented 1 year ago

Hi there, this is an issue to discuss whether you want to merge my changes. I have created a fork and released a new package. Please also see the demo repo for how to use it.

It has the following advantages:

Happy to discuss.

phoinixi commented 1 year ago

Hey @levino that is great, I wish you brought it up before writing the code. I am working on the same thing, but my idea is a bit different, I had a look at your code and you really put a lot of effort into it. I like the idea, but I will tell you why I am not merging it at this time and also present you my idea and how it differs from yours:

levino commented 1 year ago

Do not worry @phoinixi With ChatGPT helping me, it was actually okay. And I needed to have a German CV right now and not in some distant future. So even if my changes are never merged, that is okay.

Also feel free to just take part of my code (for example the .tsx files with the translated components). I guess you will need them anyhow. Also for me it was very important to have the multilanguage feature available. I already thought you might not be interested in this additional complexity so that is also fine.

On the matter of a base for "any" template, I think it is not necessary to have a react template set up but rather provide the building blocks for that, which are:

All of this stuff is in my repo and I invite you to take what you can use from there. Maybe just clone it and throw everything out, that you do not like. Could also be an idea to switch from static css to something like styled-components or tailwind-css but I think that would already be too opinionated for a template / boilerplate theme.

phoinixi commented 1 year ago

Some nice and easy higher order function that takes a react component and returns the pdfRenderOptions and the render function for resume-cli

this is the crucial part, your template is valid, I am currently working on this