phonegap-build / PushPlugin

This repository is deprecated head to phonegap/phonegap-push-plugin
https://github.com/phonegap/phonegap-plugin-push
MIT License
1.32k stars 1k forks source link

incompatibility with ongoing:true on cordova-plugin-local-notifications #681

Closed vilmar23 closed 8 years ago

vilmar23 commented 8 years ago

I'm using both plugins. And I'm getting an incompatibility when I have ongoing local notifications.

The issue is when I send the application to the background the PushPlugin cancels all notifications.

I've fixed it changing the line 119 of PushPlugin.java to:

editor.putBoolean(CLEAR_NOTIFICATIONS, jo.optBoolean(CLEAR_NOTIFICATIONS, false));

instead of true.

My question is if by doing so, I'm breaking something else somewhere?