phonegap / build

This is the public repository for PhoneGap Build source and bug tracking
92 stars 33 forks source link

[iOS] Add support to new iOS 7 icons #196

Closed amirudin closed 10 years ago

amirudin commented 10 years ago

Warnings due to missing recommended icon size. This icon size introduced to support iOS7

Warning Message: Missing recommended icon file - The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format.

Original Thread: http://community.phonegap.com/nitobi/topics/missing_recommended_icon_file

imtechnology commented 10 years ago

This is a very urgent issue which needs to be solved ASAP!

Other icon sizes are required as well!

Missing recommended icon file - The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format.

Missing recommended icon file - The bundle does not contain an app icon for iPad of exactly '76x76' pixels, in .png format.

Missing recommended icon file - The bundle does not contain an app icon for iPad of exactly '152x152' pixels, in .png format.

amarpratap commented 10 years ago

I see no one is assigned for this issue. We have been waiting for a reply on this and we need to release the application. Please help on this urgently.

bobeast commented 10 years ago

To my knowledge, Apple is not actually rejecting apps missing this icon. Rather, they are advising that a recommended icon is missing. Please verify that your app has actually been rejected.

That said, we will be rolling out our iOS 7 support soon.

amarpratap commented 10 years ago

No They are rejecting the upload. They are making the binary invalid and hence the request new binary and the same error happens again.

This has happened even as of today. This is the reason that it is a Show stopper right now.

Though the email says its warning, The status in the itunesconnect is clearly saying binary as invalid and upload a new binary.

bobeast commented 10 years ago

I currently have an App in review. I had received the same warning, but they have NOT rejected the binary. Is it possible your binary is being rejected for another reason?

I would suggest verifying with the reviewer, the reason for the rejection. My information and experience is that they should not be rejecting for this reason alone.

That said, I do recall situations where Apple's own reviewers are not all on the same page. In the meantime, I will let you know if they ultimately reject my app that is in review.

amarpratap commented 10 years ago

Sure. I will check again. The mail from them says only this for the reject. The mail also says its warning but then no other reason mentioned for the rejection.

Let me send out an email to the support as well.

amarpratap commented 10 years ago

One more thing my application doesnt even go to the review stage. It just says invalid binary and we get this email as the reason.

bobeast commented 10 years ago

Cool. Please let me know what they say. We are not quite ready for iOS 7, as it will require Build to support Cordova 3.1. If Apple is already rejecting apps for lack of iOS 7 support, it would certainly throw a big monkey wrench into the works.

abssd commented 10 years ago

My app submitted with only the 3 icon warnings. It is now Waiting For Review....

bobeast commented 10 years ago

@abssd - That is what I am seeing as well.

EddyVerbruggen commented 10 years ago

@bobeast, would it be a good temporary workaround to have a Build plugin which copies the 3 icons to the icons folder of the binary (with necessary references in the plist file)? I have one pending for review here: https://build.phonegap.com/plugins/102

bobeast commented 10 years ago

@ EddyVerbruggen - its certainly worth considering. The concern would be that it not interfere with the solution that will be provided when we roll out official iOS 7 support. Since I don't yet know what that will look like, its difficult to make the call this early.

We'll keep that one pending until we know more. - thanks

EddyVerbruggen commented 10 years ago

@bobeast I understand, that's a very good thing to keep in mind. I think though that when Build supports the icons, having the plugin in your project doesn't make a difference, as the plugin simply replaces all references in the plist. And I would ofcourse applaud delisting the plugin from the plugins page once support has been added, so no new users get confused.

shawnmckay24 commented 10 years ago

Thank you for submitting an issue. The PhoneGap Build team has triaged your request and labeled it:

  1. maintenance
  2. high priority

We've added your request to the team's backlog. Due to high volumes, there may be a delay in addressing your request. Rest assured, we haven't lost track of your request. Your feedback is very valuable to us, so please keep it coming.

If you have any questions, please ask us over on our support community. We love to help!

Cheers,

The PhoneGap Build team

IBIS-BV commented 10 years ago

Hi is this solved in 3.00 from phonegap?

batmah commented 10 years ago

10 days passed since team started resolving icon's problem. Any chance to fix it?

ghost commented 10 years ago

Hi, so just like all the others here I've wasted days and are not able to get new releases into the store! If it's a bug, then there should be a workaround. But I'm afraid it's worse, it Phonegap is simply not up to it's job. Hopefully this will be solved soon, or better, is solved already!

Cheers, Eric

ghost commented 10 years ago

YES! Believe it or not, I managed to upload an App that is now waiting for review.

How did I do it? RTFM (Apple Developer Documentation, icon and splash requirements)

It seems that the naming conventions are quite important, and that you have to store Default-586h.png, Default-586h@2x.png in the root of bundle. So, I copied these files from the splash into the root of my creative cloud project, and left a copy in splash/ios. Using the naming conventions I managed to produce a set of icons and changed my config.xml.

It compiled using build.phonegap, was uploaded to the App Store, and is now under review.... still :-)

Succes, Eric www.dreamlogic.nl

Below some important details from the config xml:

preference name="phonegap-version" value="2.7.0" />

icon src="icons/ios/icon-57.png" gap:platform="ios" width="57" height="57" /> icon src="icons/ios/icon-57_at_2x.png" gap:platform="ios" width="114" height="114" /> icon src="icons/ios/icon-72.png" gap:platform="ios" width="72" height="72" /> icon src="icons/ios/icon-72_at_2x.png" gap:platform="ios" width="144" height="144" /> icon src="icons/ios/icon-76.png" gap:platform="ios" width="76" height="76" /> icon src="icons/ios/icon-76_at_2x.png" gap:platform="ios" width="152" height="152" /> icon src="icons/ios/icon-120.png" gap:platform="ios" width="120" height="120" />

gap:splash src="splash/ios/Default.png" gap:platform="ios" width="320" height="480" /> gap:splash src="splash/ios/Default@2x.png" gap:platform="ios" width="640" height="960" /> gap:splash src="splash/ios/Default_iphone5.png" gap:platform="ios" width="640" height="1136" /> gap:splash src="splash/ios/Default-Landscape.png" gap:platform="ios" width="1024" height="768" /> gap:splash src="splash/ios/Default-Portrait.png" gap:platform="ios" width="768" height="1004" /> gap:splash src="splash/ios/Default-568h.png" gap:platform="ios" width="320" height="568" /> gap:splash src="splash/ios/Default-568@2x.png" gap:platform="ios" width="640" height="1136" />

gap:splash src="splash/ios/Default-Landscape@2x.png" gap:platform="ios" width="2048" height="1496" /> gap:splash src="splash/ios/Default-Portrait@2x.png" gap:platform="ios" width="1536" height="2008" />

ghost commented 10 years ago

Oh, and this is the link to the Apple documentation:

https://developer.apple.com/library/ios/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/App-RelatedResources/App-RelatedResources.html

Cheers, Eric

sheppard commented 10 years ago

Please update the ticket description - the missing icons are not required, they are just recommended. Apps should not be being rejected for this reason alone.

pacioos commented 10 years ago

One is listed as required (72), three others are listed as recommended (76, 120, 152). I still cannot upload my .ipa using Application Loader because of this problem. Hoping PhoneGap Build can come out with a solution soon. Here are the exact error messages from Application Loader:

ERROR ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '72x72' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iiPhone / iPod Touch of exactly '120x120' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '76x76' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '152x152' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

sheppard commented 10 years ago

72 is one of the "old" sizes, so it should theoretically work if present. I agree that it would be great if PhoneGap Build could be updated soon, but this issue shouldn't be a show-stopper as far as I can tell.

pacioos commented 10 years ago

Thanks sheppard. It looks as if the 72 size error is a recent bug in Xcode5: https://devforums.apple.com/message/886769#886769. Just FYI for others reading this list. Don't know what the solution would be for PhoneGap Build users like myself. Probably stuck until Xcode and/or PhoneGap Build can provide a fix until I can successfully submit our first app to the App Store.

ghost commented 10 years ago

I managed to upload my App after adding the -586h icon. This one is mandatory while the other three sizes are result in a warning.

See my comments posted earlier.

Eric Plugge

Op 9 okt. 2013 om 07:49 heeft "Pacific Islands Ocean Observing System (PacIOOS)" notifications@github.com het volgende geschreven:

Thanks sheppard. It looks as if the 72 size error is a recent bug in Xcode5: https://devforums.apple.com/message/886769#886769. Just FYI for others reading this list. Don't know what the solution would be for PhoneGap Build users like myself. Probably stuck until Xcode and/or PhoneGap Build can provide a fix until I can successfully submit our first app to the App Store.

— Reply to this email directly or view it on GitHub.

pacioos commented 10 years ago

Thanks anyways, but I tried all of your suggestions Eric and they didn't solve the problem. Note that my error using the Application Loader is with the 72x72 icon, not the new iOS7 sizes. As I mentioned in my previous post, there appears to be a bug in Xcode 5? A snippet from that URL below. Don't know if this is the problem and/or if it resides with PhoneGap Build. I'm still stuck. :(

"Are you using the new Image assets feature of Xcode 5?  I'm seeing it
forget to package the 72x72 icons with the actual app when I build.  I had
to revert to using manual Info.plist entries and packaging my app icon
images myself."

On Tue, Oct 8, 2013 at 9:17 PM, Eric Plugge notifications@github.comwrote:

I managed to upload my App after adding the -586h icon. This one is mandatory while the other three sizes are result in a warning.

See my comments posted earlier.

Eric Plugge

Op 9 okt. 2013 om 07:49 heeft "Pacific Islands Ocean Observing System (PacIOOS)" notifications@github.com het volgende geschreven:

Thanks sheppard. It looks as if the 72 size error is a recent bug in Xcode5: https://devforums.apple.com/message/886769#886769. Just FYI for others reading this list. Don't know what the solution would be for PhoneGap Build users like myself. Probably stuck until Xcode and/or PhoneGap Build can provide a fix until I can successfully submit our first app to the App Store.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/phonegap/build/issues/196#issuecomment-25951128 .

bobeast commented 10 years ago

Just to reiterate since there still seems to be some confusion on the subject.

1) PhoneGap Build does not yet support iOS 7. That support will roll out when we add Cordova 3.1 support, which we are currently working on.

2) Apple is NOT, I repeat NOT rejecting apps for missing any of the new iOS7 icon sizes. They are however issuing warnings.

Unfortunately people are seeing these warnings and then posting here that Apple is rejecting their apps due to missing recommended icons. This results in much running around, screaming and shouting :)

sheppard commented 10 years ago

@bobeast thanks for reiterating this point, and for your work on PhoneGap Build. @amirudin, would you be able to edit the description of this ticket to remove the phrase "apps getting rejected"? I think that wording may be contributing to the confusion, especially since it is the first thing people see when they come to this page.

@pacioos if you are using https://build.phonegap.com you shouldn't need to do anything with XCode.

bobeast commented 10 years ago

@sheppard. Good point. I have updated the issue text accordingly.

pacioos commented 10 years ago

How do you submit the .ipa to the App Store without using Xcode/Application Loader?? iTunes Connect requires this for upload, thus my conundrum. I'd be thrilled to hear of an alternative.

On Oct 9, 2013, at 7:06 AM, "S. Andrew Sheppard" notifications@github.com wrote:

@bobeast thanks for reiterating this point, and for your work on PhoneGap Build. @amirudin, would you be able to edit the description of this ticket to remove the phrase "apps getting rejected"? I think that wording may be contributing to the confusion, especially since it is the first thing people see when they come to this page.

@pacioos if you are using http://build.phonegap.com you shouldn't need to do anything with XCode.

— Reply to this email directly or view it on GitHub.

sheppard commented 10 years ago

Yes you do still need to use Application Loader - I was thinking of Application Loader as being a separate application, though I may be wrong in this interpretation. I downloaded it separately but I understand it comes with XCode as well.

bobeast commented 10 years ago

@pacioos @sheppard It seems that your issue with respect to Application Loader is unrelated to iOS7 icon warnings people are seeing. Can you kindly move this to a new issue. Thanks!

AllyEllis commented 10 years ago

Has there been a fix for this? I am getting the same errrors when trying to send via application loader an app that has been built in build:

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iiPhone / iPod Touch of exactly '120x120' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '76x76' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '152x152' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

ghost commented 10 years ago

No not yet, I've red yesterday. Ignore the warnings, it works. Only the -586h icon is mandatory. You'll see this in the email from apple after you've uploaded the ipa.

Eric Plugge

Op 10 okt. 2013 om 10:18 heeft AllyEllis notifications@github.com het volgende geschreven:

Has there been a fix for this? I am getting the same errrors when trying to send via application loader an app that has been built in build:

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iiPhone / iPod Touch of exactly '120x120' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '76x76' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

WARNING ITMS-9000: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '152x152' pixels, in .png fomat." at SoftwareAssets/SoftwareAsset (MZItmspSoftwareAssetPackage)

— Reply to this email directly or view it on GitHub.

AllyEllis commented 10 years ago

When I go back to iTunes connect it says that my binary was invalid. I have tried adding in the icons and rebuilding but still get the same.

johnblackshaw commented 10 years ago

@bobeast Although this issue may have once been just "Warnings", they are errors for me now and I can't submit my app update because of it.

error

I read this thread and got excited thinking that I was being stupid and could just click 'Send' and ignore the warnings! However, every time I try to submit my app update using the Application loader I get this error, and I can't progress. Is this a recent error in PhoneGap build? Or have Apple literally just changed their submission requirements? Either way, I'm stuck...

Any advice would be greatly appreciated! Here is my config list for reference:

gap:splash src="assets/img/splash/Default.png" width="320" height="480" gap:splash src="assets/img/splash/Default_at_2x.png" width="640" height="960" gap:splash src="assets/img/splash/Default_iphone5.png" width="640" height="1136" gap:splash src="assets/img/splash/Default-Portrait.png" width="768" height="1024" gap:splash src="assets/img/splash/Default-Portrait_at_2x.png" width="1536" height="2008"

icon src="assets/img/icons/icon.png" gap:platform="ios" width="57" height="57" icon src="assets/img/icons/icon-60.png" gap:platform="ios" width="60" height="60" icon src="assets/img/icons/icon-72.png" gap:platform="ios" width="72" height="72" icon src="assets/img/icons/icon-76.png" gap:platform="ios" width="76" height="76" icon src="assets/img/icons/icon_at_2x.png" gap:platform="ios" width="114" height="114" icon src="assets/img/icons/icon-60@2x.png" gap:platform="ios" width="120" height="120" icon src="assets/img/icons/retina_ipad.png" gap:platform="ios" width="144" height="144" icon src="assets/img/icons/icon-76@2x.png" gap:platform="ios" width="152" height="152"

johnblackshaw commented 10 years ago

@bobeast Appears to have literally been fixed in the past few minutes and I've managed to submit my app. Thank you Bob you beautiful beast!

http://community.phonegap.com/nitobi/topics/missing_recommended_icon_file

bobeast commented 10 years ago

The errors should now be gone.

patrickbense commented 10 years ago

Bob, I am still having this issue. I am building with PhoneGap 2.9.0 and trying add through the Application Loader on OSX Mountain Lion and XCode 5. I am still getting the errors for the icon sizes of 72px and 57px. I am unable to submit for approval at this time. Any ideas?

bobeast commented 10 years ago

H Patrick. Can you please attach a screen shot of the error message? thanks.

patrickbense commented 10 years ago

screenshot

I wrote more of an explaination here Bob: http://community.phonegap.com/nitobi/topics/missing_recommended_icon_file

I REALLY appreciate you looking into this so quickly, as we are under a tight deadline to get this into approval ASAP. Thank you for your understanding and your hard work.

bobeast commented 10 years ago

@Patrick - Your problem is that your images are not sized correctly. For example your image titled Icon-57.png is actually 238 x 238 whereas it should be 57 x 57.

Its probably not clear from the documentation, but it is not enough to have your images named correctly, the actual size of the images have to be correct as well because the Appstore review process checks the internal image size.

Resize all of your images as appropriate, and you should be good to go.

patrickbense commented 10 years ago

Bob, you're a life saver! I don't know how I overlooked that, but nonetheless thank you. I think the documentation iclear enough as that seems pretty obvious. I swore I created those correctly but I did not.

Thanks again!

bobeast commented 10 years ago

You are very welcome

AllyEllis commented 10 years ago

Hi Bobeast. I am having the same issue too. Would you possibly be able to point me in the correct direction.

I know that all of my images are the correct size. Here is my XML for the icons

<icon src="icon.png" />

<icon src="icons/icon-iphone-57.png" gap:platform="ios" width="57" height="57"/>
<icon src="icons/icon-iphone-72.png" gap:platform="ios" width="72" height="72"/>

<icon src="icons/ios/icon.png" gap:platform="ios" width="152" height="152"/>
<icon src="icons/ios/icon2.png" gap:platform="ios" width="120" height="120"/>
<icon src="icons/ios/icon3.png" gap:platform="ios" width="76" height="76"/>

But I still get the error. The error page is below. I am a bit stumped with this.

phonegap_errors

Any help greatly appreciated

Ally

bobeast commented 10 years ago

@AllyEllis - Those are not errors, they are warnings which can safely be ignored for the time being. Those warnings should go away once we add full support for iOS7.

AllyEllis commented 10 years ago

Thanks @bobeast
In Itunes Connect it says that the binary is invalid, so this means it cannot be made available on itunes. Is there any way to make this available on the itunes store or do we have to wait until there is IOS7 support? Ally

bobeast commented 10 years ago

@AllyEllis - I would suggest rejecting the binary on iTunes connect. then attempt to re-submit it via Application Loader. The 'invalid binary' may be a left-over issue from previous submission attempt. Apple is NOT rejecting binaries for the missing icon warnings. Thus if you are still having problems,you might wish to contact Apple's submission support team.

AllyEllis commented 10 years ago

Thanks BOB. I have tried rejecting the binary and re submitting several times now and and keep getting the same issue. So this definitely is not a problem with phonegap?

bobeast commented 10 years ago

@ AllyEllis - I'll avoid the tern "definitely :) However, in the absence of evidence to the contrary, it really doesn't sound like a PhoneGap Build issue.

Tell you what...Tell me your app ID and I'll see if I can see anything obvious.

AllyEllis commented 10 years ago

Thank you so much. My app is 88217.

I have tried so many things to get this to work but end up getting the same result every time.

Ally