phonegap / build

This is the public repository for PhoneGap Build source and bug tracking
92 stars 33 forks source link

gap:config-file not working #647

Open pastet89 opened 5 years ago

pastet89 commented 5 years ago

No matter what I try I cannot get the gap:config-file to work. The build compiles without errors, but there are no changes in the AndroidManifest.xml.

This is my code:

   <gap:config-file platform="android" parent="/application">
        <meta-data android:name="google_analytics_adid_collection_enabled" android:value="false" />
    </gap:config-file>  

I tried also: 1) Putting it into the <platform name="android"> node and out of it. 2) Tried: parent="/application", parent="/manifest/application"

andersborgabiro commented 5 years ago

This is how it's done now: https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#edit-config

pastet89 commented 5 years ago

@andersborgabiro Thanks, however, it didn't work for me either. I spent few hours trying all combinations I could think of, tried both eidt-config and config-file, various Xpath values, inside and outside the Android platform node, nothing works for me.

andersborgabiro commented 5 years ago

I've only used edit-config for iOS, so I don't have a good example. It no doubt works there. Do you use cli-8.0.0?

pastet89 commented 5 years ago

No, I use cli-7.0.1 and I build online through build.phonegap.com.

andersborgabiro commented 5 years ago

Any reason for doing that? cli-7.0.1 is very old. I use PGB too.

pastet89 commented 5 years ago

Actually, yes. I can't remember exactly what was it, but there was some kind of bug which required me to explicitly use that version. Anyway, I will try to repack and edit AndroidManifest.xml using apktool, thanks for your time!

On Tue, Mar 19, 2019 at 1:19 AM Anders Borg notifications@github.com wrote:

Any reason for doing that? cli-7.0.1 is very old. I use PGB too.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/phonegap/build/issues/647#issuecomment-474138211, or mute the thread https://github.com/notifications/unsubscribe-auth/AHH4Ad006H_vYJaxefHsUy5lUj3i_52Uks5vYB7mgaJpZM4b6aFX .