search

phonegap / connect-phonegap

Stream a PhoneGap app to any device.
Apache License 2.0
61 stars 63 forks source link

Fixing proxy middleware w.r.t. redirect responses #198

Closed filmaj closed 7 years ago

filmaj commented 7 years ago

This fixes #197.

Also added tests that leverage a second HTTP server to better be able to control server responses when exercising the proxy middleware.

codecov[bot] commented 7 years ago

Codecov Report

Merging #198 into master will increase coverage by 0.6%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #198     +/-   ##
=========================================
+ Coverage   89.11%   89.71%   +0.6%     
=========================================
  Files          24       24             
  Lines         450      457      +7     
  Branches       84       85      +1     
=========================================
+ Hits          401      410      +9     
+ Misses         49       47      -2
Impacted Files Coverage Δ
lib/middleware/proxy.js 100% <100%> (+13.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8875090...e63c4ab. Read the comment docs.