search

phonegap / node-phonegap-build

PhoneGap Build node module to login, create, and build apps.
Apache License 2.0
26 stars 25 forks source link

Node 10 requires a callback to rmdir #69

Open gust42 opened 5 years ago

gust42 commented 5 years ago

Makes it work with Node 10

frederikbosch commented 5 years ago

It would be nice if this could be merged so Node 10 is supported.

angelika94 commented 5 years ago

It would be nice if this could be merged so Node 10 is supported.

+1

r1si commented 5 years ago

+1 please merge!

sebastianjonasson commented 5 years ago

Not ideal, but I solved this by just updating the source (as in PR) locally. https://github.com/phonegap/node-phonegap-build/issues/68

badpenguin commented 5 years ago

Wow still not merged? I've got the same problem today and this fixed it.

andycorm commented 4 years ago

I'm not so awesome at all this node/phonegap config stuff, and my remote build is failing as well. Can someone explain for us dummies how we'd go about using this patched gust42 version of phonegap build?

gust42 commented 4 years ago

I'm not so awesome at all this node/phonegap config stuff, and my remote build is failing as well. Can someone explain for us dummies how we'd go about using this patched gust42 version of phonegap build?

you can find the file locally on your computer and make the changes, lib/phonegap-build/create/zip.js

sami016 commented 4 years ago

Need this also. Is the project dead/inactive?

spraddles commented 4 years ago

please merge this! this issue has existed for more than a year now! thanks :-)